ensure that single-rid container publishes populate all container information #48584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48579
This is a proposed change to the container targets to ensure that for single-rid containers the existing
ComputecontainerConfigcontract holds.NOTE: we need to add a test verifying that all the run-time-related information is present for single-rid builds after calling the ComputeContainerConfig target so that we don't regress this in the future.
For a single-RID container publish:
Here you can see that by the time ComputeContainerConfig is completed the execution-time properties have been set.
For a multi-RID container publish, the 'outer' parts are computed:
And then the per-RID parts are just-in-time called before each RID's container publish:
